Overview

SimpleQueue uses a visibility-timeout redelivery model: a dequeued item is re-scored and left in the sorted set, and it only leaves the queue when it is acked or moved to the dead-letter queue (DLQ).

Before: When SimpleQueue.dequeue() encountered an item it could not process — one whose job field was not a string, one whose job had no registered schema, or one whose payload failed schema validation — it logged an error and skipped the item. Because nothing removed it, the item was re-scored and redelivered on the next visibility-timeout cycle, and this repeated on every cycle indefinitely (a poison-message loop).

After: Each of these three cases is unrecoverable — retrying cannot make the item's job or payload valid — so on first encounter the item is moved to the dead-letter queue and never redelivered. This mirrors how the max-attempts path in worker.ts already handles valid-but-failing handlers.

How

In SimpleQueue.dequeue(), the three "invalid item" branches (non-string job, missing schema, failed safeParse) now await this.moveToDeadLetterQueue(id, <reason>) before continue, instead of only logging and skipping. moveToDeadLetterQueue removes the item from the main queue and records its payload and the error in the DLQ. The existing error logs are kept for context.

✅ Checklist

• I have followed every step in the contributing guide
• The PR title follows the convention.
• I ran and tested the code works

Testing

Added tests in packages/redis-worker/src/queue.test.ts covering the unknown-job and unparseable-payload cases: each asserts the item is moved to the DLQ, the main queue is emptied, and the item does not resurface on a subsequent dequeue().

Changelog

SimpleQueue.dequeue() now moves unrecoverable items (invalid job field, unknown job schema, or payload that fails schema validation) to the dead-letter queue on first encounter instead of logging and silently re-queuing them, preventing an indefinite redelivery loop.

Screenshots

N/A

💯

Generated by Claude Code